Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardizes the combobox selectionStrategy name to autoSelectMatch #914

Merged

Conversation

loesking
Copy link
Contributor

@loesking loesking commented Nov 8, 2024

This PR unifies the naming of one of the selectionStrategy options in the combobox to autoSelectMatch. I noticed that the Fritz2 documentation referred to this strategy as autoSelectMatches, which is incorrect. To prevent future inconsistencies, I decided to standardize the terminology across the entire project.

@haukesomm haukesomm added the documentation Improvements or additions to documentation label Nov 8, 2024
@haukesomm haukesomm added this to the 1.0-RC20 milestone Nov 8, 2024
@haukesomm haukesomm self-requested a review November 8, 2024 08:59
Copy link
Collaborator

@haukesomm haukesomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your corrections, everything looks fine :)

@haukesomm haukesomm merged commit 5c52ffa into jwstegemann:master Nov 8, 2024
2 checks passed
@loesking loesking deleted the lloesking/autoSelectMatch-terminology branch November 8, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants