Combobox: Only accept distinct values via data-binding #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adjust the combobox's data-binding to only accept values that are different from the previous selection. In most cases, this should not make a difference. There are corner cases, however, where the value is quickly updated multiple times in a row, causing the internals to run into race-conditions. The above changes should prevent this issue.
haukesomm
added
bug
Lysander
approved these changes
Nov 6, 2024
haukesomm
pushed a commit
that referenced
this pull request
Nov 6, 2024
This commit adjust the combobox's data-binding to only accept values that are different from the previous selection. In most cases, this should not make a difference. There are corner cases, however, where the value is quickly updated multiple times in a row, causing the internals to run into race-conditions. The above changes should prevent this issue. (cherry picked from commit 928a942)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the combobox's data-binding to only accept values that are different from the previous selection.
In most cases, this should make no difference. There are corner cases, however, where the value is quickly updated multiple times in a row, causing the internals to run into race-conditions.
Fixes #912