Fixes some potential bug with mapping lenses #910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pimped `className`-function (introduced by PR #823 in `1.0-RC15` release) did not apply exception handling. That could lead to errors, if there is code that removes some element: The independent reactive renderings could simply lead to corner cases, where a lens will try to access its mapped object (e.g. by `mapByElement`) that is no longer part of the stored model. So a `CollectionLensGetException` will be thrown and must be handled by the consuming code. This PR adds such exception handling code and a unit test to verify the new, correct behaviour.
Lysander
force-pushed
the
chausknecht/add-classname-exception-handling
branch
from
9010c5c to
7a582ea
Compare
haukesomm
approved these changes
Oct 21, 2024
Lysander
added a commit
that referenced
this pull request
Oct 22, 2024
The pimped `className`-function (introduced by PR #823 in `1.0-RC15` release) did not apply exception handling. That could lead to errors, if there is code that removes some element: The independent reactive renderings could simply lead to corner cases, where a lens will try to access its mapped object (e.g. by `mapByElement`) that is no longer part of the stored model. So a `CollectionLensGetException` will be thrown and must be handled by the consuming code. This PR adds such exception handling code and a unit test to verify the new, correct behaviour. Co-authored-by: christian.hausknecht <christian.hausknecht@oeffentliche.de> (cherry picked from commit fc099ae)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pimped
className-function (introduced by PR #823 in1.0-RC15release) did not apply exception handling. That could lead to errors, if there is code that removes some element:The independent reactive renderings could simply lead to corner cases, where a lens will try to access its mapped object (e.g. by
mapByElement) that is no longer part of the stored model. So aCollectionLensGetExceptionwill be thrown and must be handled by the consuming code.This PR adds such exception handling code and a unit test to verify the new, correct behaviour.