Improve PopUpPanel Performance #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 10, 2024 13:27
- confines the `autoUpdate` mode from `floating-ui` to only opened panels, which should increase speed massively when lots of `PopUpPanel` based components are in scope - fixes some [issue](floating-ui/floating-ui#1740) of `floating-ui` with DOM's resize observer by applying some mentioned workaround (setting `elementResize = false` in den `autoUpdate` options)
haukesomm
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
autoUpdatemode fromfloating-uito opened panels only, which should increase speed massively when lots ofPopUpPanelbased components are in scopefloating-uiwith DOM's resize observer by applying some mentioned workaround (settingelementResize = falsein denautoUpdateoptions)