Improves PopUpPanel #835
Merged
Improves PopUpPanel #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lysander
added
api improvement
headless
- extends `arrow`-factory to take some `offset`-parameter alongside to the size parameter that is meant for changing width and height - improves default styling, so that the arrow is located behind the panels content - adds, corrects or improves API- and prose-documentation regarding the `PopUpPanel` usage, `arrow`-usage or `middleware`-usage.
Lysander
force-pushed
the
chausknecht/improvePopUpPanel
branch
from
11a8393 to
e64d5dc
Compare
metin-kale
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
arrow-factory to take someoffset-parameter alongside to the size parameter that is meant for changing width and heightPopUpPanelusage,arrow-usage ormiddleware-usage.This can be tested with the following snippet. Just paste it somewhere into the
headless-demo:popOver { popOverButton(classes = "mr-3 mt-2") { +"Click me" } popOverPanel("z-30 bg-gray-100") { arrow("w-10 h-10", 25) div("p-3 py-4") { +"With Arrow Beneath Text!" } } }