-
Notifications
You must be signed in to change notification settings - Fork 30
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixes some potential bug with mapping lenses
The pimped `className`-function (introduced by PR #823 in `1.0-RC15` release) did not apply exception handling. That could lead to errors, if there is code that removes some element: The independent reactive renderings could simply lead to corner cases, where a lens will try to access its mapped object (e.g. by `mapByElement`) that is no longer part of the stored model. So a `CollectionLensGetException` will be thrown and must be handled by the consuming code. This PR adds such exception handling code and a unit test to verify the new, correct behaviour.
- Loading branch information
christian.hausknecht
committed
Oct 21, 2024
1 parent
2f1868c
commit e870511
Showing
2 changed files
with
49 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters