-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Residual errors are 0 #92
Comments
Hi @ZvejysMegejas, would you please share the code and the full error message? |
Please find at https://github.com/ZvejysMegejas/rascalcodeexample I noticed that if plots are send to a browser (plotly feature?), then the residual error is shown correctly. However, if plotting is done with pyplot (?), the error is flat. I'll try to write my own code with 'plotly' using your examples. |
Thanks, that's a really good place to start! |
This is also fixed in the dev-0.3.X branch. |
Ha! @jveitchmichaelis, is that an old bug creeping back or a wontfix in v0.3? |
Did we figure out this one @cylammarco ? |
Hi,
I'm a new user of Rascal. Trying to use it to calibrate the spectrometer. After messing around with custom atlas lines and all other setting I managed to get satisfactory line matches. However I noticed that the Residual error and RMS were shown as zeros in c.plot_fit. I looked in the code of the plot.fit in plotting.py, and I have feeling that the error sits over there. As I'm a new Python user as well, I can not pinpoint where is that exactly as the code for the Residual Error calculations seems complicated for me. A simpler code gives "proper" numbers for Residual error.
peaks_angstr = c.polyval(matched_peaks, fit_coeff1)
diff = []
for i, j in zip(peaks_angstr, matched_atlas):
diff.append(i - j)
print(diff)
# RMS calculations
rms = np.sqrt(np.mean(np.array(diff) ** 2.0))
print(rms)
The text was updated successfully, but these errors were encountered: