Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding min_pixel and max_pixel to set_hough_properties #88

Open
cylammarco opened this issue Dec 4, 2022 · 0 comments
Open

Adding min_pixel and max_pixel to set_hough_properties #88

cylammarco opened this issue Dec 4, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@cylammarco
Copy link
Collaborator

In set_hough_properties, min_wavelength and max_wavelength are referring to the wavelength at pixel 0 and the wavelength at the last pixel.

In some arcs, there are only lines in half of the frame, it would make sense to fit only the region where there are peaks. In any case, it would be generally easier to understand what the limits are when we twin-up the min_wavelength with a min_pixel, and a max_wavelength with a max_pixel.

@cylammarco cylammarco added the enhancement New feature or request label Dec 4, 2022
@cylammarco cylammarco added this to the v0.4.0 milestone Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants