Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start fitting with a good set of polynomial #57

Open
cylammarco opened this issue Aug 21, 2022 · 2 comments
Open

Start fitting with a good set of polynomial #57

cylammarco opened this issue Aug 21, 2022 · 2 comments
Assignees
@jveitchmichaelis
Labels
enhancement New feature or request urgent
Milestone
v0.4.0

Comments

@cylammarco
Copy link
Collaborator

Use a set of user-defined polynomials as an "initial condition".
@cylammarco cylammarco added the enhancement New feature or request label Aug 22, 2022
@cylammarco
Copy link
Collaborator Author

It is currently done via setting linear to False in set_ransac_properties, and then supply a set of polynomial coefficients in fit. It doesn't work very well at the moment.

@cylammarco
Copy link
Collaborator Author

There is an experimental method Calibrator._get_candidate_points_poly() that is currently failing. Either fix/extend this or try something else.

match_peaks can also "refit" using the given polynomial, but it only works if the starting condition is already good.

@cylammarco cylammarco added this to the v0.4.0 milestone Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jveitchmichaelis jveitchmichaelis

Labels
enhancement New feature or request urgent
Projects
None yet
Milestone
v0.4.0
Development

No branches or pull requests
2 participants
@cylammarco @jveitchmichaelis