Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atlas filtering based on estimated dispersion #5

Open
jveitchmichaelis opened this issue Dec 9, 2019 · 1 comment
Open

Atlas filtering based on estimated dispersion #5

jveitchmichaelis opened this issue Dec 9, 2019 · 1 comment
Assignees
Labels
documentation Improvements or additions to documentation help wanted Extra attention is needed

Comments

@jveitchmichaelis
Copy link
Owner

jveitchmichaelis commented Dec 9, 2019

Currently we just extract all atlas lines between two wavelengths. While it's useful to store all catalogue lines, it can confuse the algorithm:

  • if line separation is lower than the resolution of the instrument
  • during preliminary peak/arc line matching there is a higher uncertainty in matching multiple close atlas lines to a single peak (particularly if only one peak in a group is extracted)

We can't necessarily filter by relative intensity because this is instrument specific and small peaks at the edge of the spectrum can be critical for accurate fitting.

Proposal:

  • Optional (default true) ignore atlas lines which are closer together than the lowest possible resolution we expect (e.g. ((end_wavelength + tolerance) - (start_wavelength - tolerance))/n_pix)
  • Once a good coarse calibration has been obtained, fit again using much stricter matching criteria (could repeat this until the final set of matches doesn't change).
  • Could initially use high relative intensity lines + peaks for RANSAC, and then relax this criteria for later fitting.
cylammarco added a commit that referenced this issue Jan 6, 2020
@cylammarco cylammarco added the enhancement New feature or request label Jan 6, 2020
@cylammarco cylammarco added documentation Improvements or additions to documentation help wanted Extra attention is needed labels Jan 6, 2020
@cylammarco cylammarco added this to the V0.1 milestone Jan 23, 2020
@cylammarco cylammarco removed the enhancement New feature or request label May 13, 2020
@cylammarco
Copy link
Collaborator

Also refer to #16

@cylammarco cylammarco removed this from the V0.3.0 milestone Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants