-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TCP protocol support. #538
TCP protocol support. #538
Conversation
Updated tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. It looks like some of the tests are failing though.
Unused namespaces have been removed.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #538 +/- ##
==========================================
+ Coverage 83.18% 83.77% +0.59%
==========================================
Files 28 28
Lines 666 672 +6
Branches 150 151 +1
==========================================
+ Hits 554 563 +9
+ Misses 70 67 -3
Partials 42 42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks for your contribution @firerain-fd, this looks good. Could you confirm that you've tried this out with the use cases you think you'd use it for and that is fulfills those needs? Gives us some extra confirmation beyond whatever is in our test suite. Other than that, I'm not going to merge this yet as we've been rather lax with actually releasing all the pent-up change in our main branch for a while and that's some admin I need to work through when I get the time to sort it out. Once things are prepped for a new release, then I'll merge this and we can look at finally shipping a new version. |
Yes, I checked this in my project. Now I can get an exception when it is impossible to connect to statsd server or when I fail to send a request. |
TCP protocol support has been added.
Updated tests.
#537