-
-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Notebook 7 #827
Support Notebook 7 #827
Conversation
@jtpio Thank you so much for exploring how to support this feature! I'm excited to be able to use Jupyter AI in Notebook now. BTW, #828 calls a few more JupyterLab APIs to implement error output detection, which may impact this PR. Since #828 changes more significant lines of code, I believe it will be easier to have #828 reviewed & merged first before addressing potential conflicts in this PR. I will help with the rebase if the conflicts are clear for me to resolve independently. |
Looks like there were no conflicts after the merge of #828 👍 |
Co-authored-by: david qiu <david@qiu.dev>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jtpio Awesome work, thank you so much! Tested & verified locally in both JupyterLab and Jupyter Notebook. Looking forward to making this available to users.
* Support Notebook 7 * Mention Notebook 7 in the docs * fix IStatusBar requirement * Update docs/source/users/index.md Co-authored-by: david qiu <david@qiu.dev> * move notebook 7 note in the docs --------- Co-authored-by: david qiu <david@qiu.dev>
Fixes #504
Rely on the new (optional)
currentChanged
signal added to theJupyterFrontend.IShell
interface in JupyterLab 4.2.0: jupyterlab/jupyterlab#15449. Which requires bumping the@jupyterlab/application
package to^4.2.0
.This should not change anything for JupyterLab users. However since Notebook 7 also implement this signal, this makes it possible to use Jupyter AI in Notebook 7
Changes
@jupyterlab
packages to 4.2Screenshots