Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Notebook 7 #827

Merged
merged 5 commits into from
Jun 17, 2024
Merged

Support Notebook 7 #827

merged 5 commits into from
Jun 17, 2024

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Jun 11, 2024

Fixes #504

Rely on the new (optional) currentChanged signal added to the JupyterFrontend.IShell interface in JupyterLab 4.2.0: jupyterlab/jupyterlab#15449. Which requires bumping the @jupyterlab/application package to ^4.2.0.

This should not change anything for JupyterLab users. However since Notebook 7 also implement this signal, this makes it possible to use Jupyter AI in Notebook 7

Changes

  • Bump @jupyterlab packages to 4.2
  • Update docs to mention the extension is compatible with Notebook 7.2.0+

Screenshots

image

image

@jtpio jtpio added the enhancement New feature or request label Jun 11, 2024
@jtpio jtpio marked this pull request as ready for review June 11, 2024 15:37
docs/source/users/index.md Outdated Show resolved Hide resolved
docs/source/users/index.md Outdated Show resolved Hide resolved
@dlqqq
Copy link
Member

dlqqq commented Jun 11, 2024

@jtpio Thank you so much for exploring how to support this feature! I'm excited to be able to use Jupyter AI in Notebook now.

BTW, #828 calls a few more JupyterLab APIs to implement error output detection, which may impact this PR. Since #828 changes more significant lines of code, I believe it will be easier to have #828 reviewed & merged first before addressing potential conflicts in this PR. I will help with the rebase if the conflicts are clear for me to resolve independently.

@jtpio
Copy link
Member Author

jtpio commented Jun 12, 2024

BTW, #828 calls a few more JupyterLab APIs to implement error output detection, which may impact this PR. Since #828 changes more significant lines of code, I believe it will be easier to have #828 reviewed & merged first before addressing potential conflicts in this PR. I will help with the rebase if the conflicts are clear for me to resolve independently.

Looks like there were no conflicts after the merge of #828 👍

@jtpio jtpio requested a review from dlqqq June 13, 2024 13:10
Copy link
Member

@dlqqq dlqqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jtpio Awesome work, thank you so much! Tested & verified locally in both JupyterLab and Jupyter Notebook. Looking forward to making this available to users.

@dlqqq dlqqq merged commit ff022fe into jupyterlab:main Jun 17, 2024
8 checks passed
@jtpio jtpio deleted the notebook-7 branch June 18, 2024 05:58
Marchlak pushed a commit to Marchlak/jupyter-ai that referenced this pull request Oct 28, 2024
* Support Notebook 7

* Mention Notebook 7 in the docs

* fix IStatusBar requirement

* Update docs/source/users/index.md

Co-authored-by: david qiu <david@qiu.dev>

* move notebook 7 note in the docs

---------

Co-authored-by: david qiu <david@qiu.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Notebook 7
2 participants