Improve submit_batch_script logging #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmd-ntrf
force-pushed
the
log
branch
2 times, most recently
from
8e7cc30 to
7836a53
Compare
consideRatio
reviewed
Apr 6, 2022
| out = await self.run_command(cmd, input=script, env=self.get_env()) | ||
| try: | ||
| self.log.info("Job submitted. cmd: " + cmd + " output: " + out) | ||
| self.log.info("Job submitted. output: %s", out) |
There was a problem hiding this comment.
If multiple spawners work at the same time, I figure this could be confusing to have written out in multiple separate lines - especially if there is a await in between that could make jobs print multiple messages that intermix.
Due to that, it may make sense to help the admin distinguish what spawner is printing what as well - then it would be without problem to remove logging cmd again in this place I think.
|
Hi, after we update the test matrix can you make a commit to this to trigger rerunning the CI? |
|
This looks reasonable, thank you @cmd-ntrf! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds:
subvars(info)self.get_env(debug)Changes:
infotodebug.The rational is that it is easier to parse
subvarsdictionary in a separate log than the multiline submit script, which would then be only useful in a debug context.Removes:
cmdfrom theJob submittedinfo log, since it is was already logged before.This PR also introduces the usage of logging argument instead of concatenating string with
+.I will follow with a second PR that standardize logging to use argument instead of string concatenation systematically.