Issue controls panel UI #81
Conversation
|
|
IsabelParedes
added
bug
Yahiewi
force-pushed
the
issue-controls-panel-ui
branch
from
7403b2d to
2246948
Compare
|
Resolves #57 |
There was a problem hiding this comment.
This is going in the right direction, but it could be better. At the moment, when the panel is resized, all 3 columns (joint names, sliders, and input boxes) stretch. We should keep the width of the sliders and input boxes fixed so that the joint names can occupy the newly created space when resizing the gui.
| @@ -123,7 +123,7 @@ export class URDFRenderer extends THREE.WebGLRenderer { | |||
| * Adds three lights to the scene | |||
| */ | |||
| private _addLights(): void { | |||
| const directionalLight = new THREE.DirectionalLight(0xffffff, 1.0); | |||
| const directionalLight = new THREE.DirectionalLight(0xff0000, 1.0); | |||
There was a problem hiding this comment.
Changes to the lighting are not related to what this PR is trying to fix. These changes should be moved to a separate PR.
| // Add resize functionality | ||
| this._setupResizeHandling({ | ||
| minWidth: 150, | ||
| maxWidth: 500, |
There was a problem hiding this comment.
Maybe it's better to not restrict the max width. If the user wants the gui to occupy the full width of the window, that should be possible and it might be useful for extra long joint names.
Made the controls panel resizable to manly fix the issue of joint names being too long to read:
-Added the pseudo element .urdf-gui::before in base.css for the invisible handle.
-Added a min and max width for the panel.
-Overwritten style for the "close controls" button to fix some issues.
-Added a function _setupResizeHandling in controls.ts to implement this.