Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Documentation update for newer versions Jupyter notebook #902

Merged

Conversation

andormarkus
Copy link

Description

The installation procedures of the ipywidgets significantly different for newer Jupyter Notebook and JupyterLab releases. If the user follows the current installation procedures for newer releases the installation will fail.

This PR closes:

Provide better solution for:

Checklist

  • Wrote a description of my changes above
  • [NA] Formatted my code with black
  • Added a bullet point for my changes to the top of the CHANGELOG.md file
  • [NA] Added or modified unit tests to reflect my changes
  • Manually tested with a notebook
  • [NA] If adding a feature, there is an example notebook and/or documentation in the README.md file

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. kind:documentation Related to updating, improving, or fixing documentation labels May 1, 2024
@devstein devstein self-requested a review May 2, 2024 02:13
@devstein
Copy link
Collaborator

devstein commented May 2, 2024

@andormarkus thank you for contributing! I'll try to take a look later this week(end)

@devstein
Copy link
Collaborator

devstein commented May 2, 2024

Also heads up CI broke two days ago due to some upstream unpinned dependency change. I haven't looked into it, but should hopefully be a straightforward fix

@devstein
Copy link
Collaborator

Hey @andormarkus are you able to update your fork to the latest changes on master?

@devstein devstein merged commit f542e7e into jupyter-incubator:master Nov 13, 2024
8 of 14 checks passed
@devstein
Copy link
Collaborator

Merged as part of #935

@devstein
Copy link
Collaborator

Thanks for contributing @andormarkus!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:documentation Related to updating, improving, or fixing documentation size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants