-
Notifications
You must be signed in to change notification settings - Fork 14
Logging init config logic minor modifications #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
li-ruihao
wants to merge
9
commits into
junhaoliao:main
Choose a base branch
from
li-ruihao:logging_init_config_logic_changes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
fcc2d76
Logic changes to logging initialization and configuration in applicat…
li-ruihao 2d6129e
Added comments in application\__init__.py
li-ruihao 74e7f21
Minor changes in application/__init__.py according to coderabbitai's …
li-ruihao bfb69cc
Reverted a small change in application/__init__.py, config variable i…
li-ruihao 4b46a72
changed logging statements to use %s operators, instead of f-strings
li-ruihao f86f53d
Changes made to application/__init__.py based on code review
li-ruihao a52c34b
Merge remote-tracking branch 'upstream/main' into logging_init_config…
li-ruihao 54bee53
minor changes to fix logger initialization
li-ruihao f5ba40f
minor changes from code review
li-ruihao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick (assertive)
Consider limiting logged configuration details.
Logging the entire configuration object could potentially expose sensitive information (like log file paths, credentials in custom handlers) and create verbose log entries.
📝 Committable suggestion