Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract function to pull df of node annotations for treeview #23

Open
wants to merge 10 commits into
base: staging-wp5
Choose a base branch
from

Conversation

russHyde
Copy link
Collaborator

This relates to trimming the tooltip text for tree views.
Several internal nodes had undefined cluster IDs when the data for scanner-env-2022-08-01.rds was presented in tfpbrowser.
To simplify debugging where those missing (NA) cluster IDs were defined, we extracted a function that defines the data that annotates the nodes in a tree plot away from treeview().

This removes a few temporary variables from inside treeview() (sc2, tdvars, td0, td1).

(By the way, the internal nodes that end up with NA cluster IDs all derive from the temporary 'x' variable that is generated in the "# internal" section where td1 is defined; I'm currently a bit stuck working out how to map these tree-node IDs to cluster IDs)

russHyde and others added 5 commits December 5, 2022 11:48
Draft: ci: add bioconductor CI checks (biocthis::use_bioc_github_action)
Revert "ci: add bioconductor CI checks (biocthis::use_bioc_github_act…
@russHyde russHyde requested a review from jr-nicola January 18, 2023 17:10
@jr-nicola
Copy link

jr-nicola commented Jan 20, 2023

I'm currently a bit stuck working out how to map these tree-node IDs to cluster IDs)

Do any of the nodes have a tree-node ID and a cluster ID, and if there ever a case where the same number is used for a cluster ID and a tree-node ID?

I'm wondering if the tree node ID should be used instead of the cluster ID in the cases where there is no cluster ID. Do you have a couple of examples of tree-node numbers and we can look to see if there's a folder with that number?

Would it be possible to export the labelling data somehow, with the node number from ggplot and the clusterID - to call that directly in tfpbrowser, instead of trying to parse the tooltips again?

@russHyde
Copy link
Collaborator Author

I can have a look, but, the tree node IDs are an integer sequence (1:x for the x leaves, x+1 : x+y for the y internal nodes). My understanding is this node ID is just for internal representation and doesn't relate to something important within the dataset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants