-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trim tooltip #20
base: staging-wp5
Are you sure you want to change the base?
Trim tooltip #20
Conversation
Draft: ci: add bioconductor CI checks (biocthis::use_bioc_github_action)
…ion)" This reverts commit 1e6b024.
be9a225
to
a969811
Compare
I think the tooltip looks a bit scruffy. There's a preceding newline (possibly due to a hidden kable header) and there is the data.frame "Column.NAME" dot-separation mangling going on. I can fix these to just say ---------
Cluster ID NNNNN
--------- or just Cluster ID: NNNNN |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I'd probably go for the second option of having just:
Cluster ID: NNNNN
Thanks @jr-nicola I'll modify the tooltip text |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
When I ran this updated version on the larger data set and tried to parse the tooltips to get the cluster ID as a numeric, I got a couple of examples where the label was:
I assume these were already in the previous version, and our parsing just didn't return an error the previous time? |
I've just reran the code here. Calling |
Revert "ci: add bioconductor CI checks (biocthis::use_bioc_github_act…
Staging wp3 mrc
3fac6ff
to
3961cc4
Compare
Work package 5
The genotype columns were being made in `append_interactivity_data` but were not presented by the interactive tooltip. Hence, they are now defined in `extract_genotype_data`
The text that is displayed when the user mouse-overs a node on the treeview contained lots of information.
Here, we trim down the text to just display the cluster ID for the hovered node.
The original code (in
append_interactivity_data
) made a lot of changes to the "$data" data.frame in a ggtree object (adding "defmuts", "allmuts", "mouseover", "colour_var" columns, and a column for each mutation regex that is passed intoappend_interactivity_data
). Of these, the only columns that were actually used when setting up the interactive ggtree/girafe object were "colour_var" and "mouseover" and the mutation regex columns were used when making the genotype-heatmap.We removed the "defmuts" column because this isn't presented by the tooltip, and isn't used in any other downstream processing step.
The "allmuts" column was not kept in either. But for different reasons. It is used to create the mutation-regex columns that the mutation heatmap is made from. Rather than defining these columns in
append_interactivity_data
(since they aren't presented 'interactively' to the user) they are now defined byextract_genotype_data
where they are used to define the heatmap matrix and are thrown away.