Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FF8: Fix external texture reload #759 #761

Merged
merged 2 commits into from
Dec 4, 2024
Merged

FF8: Fix external texture reload #759 #761

merged 2 commits into from
Dec 4, 2024

Conversation

myst6re
Copy link
Contributor

@myst6re myst6re commented Dec 4, 2024 •
edited
Loading

Summary

Fix external texture reload when different textures uses the same texture set

Motivation

#759

ACKs

  • I have updated the Changelog.md file
  • N/A I did test my code on FF7
  • I did test my code on FF8

@myst6re myst6re force-pushed the fix/ff8-external-texture-reload branch from 0882fa0 to 16e71ed Compare December 4, 2024 20:43
@myst6re myst6re marked this pull request as ready for review December 4, 2024 20:44
@myst6re myst6re marked this pull request as draft December 4, 2024 20:46
@myst6re myst6re marked this pull request as ready for review December 4, 2024 21:01
julianxhokaxhiu
julianxhokaxhiu previously approved these changes Dec 4, 2024
View reviewed changes
@julianxhokaxhiu julianxhokaxhiu added the bug Something isn't working label Dec 4, 2024
@julianxhokaxhiu julianxhokaxhiu added this to the 1.21.1 milestone Dec 4, 2024
@julianxhokaxhiu julianxhokaxhiu linked an issue Dec 4, 2024 that may be closed by this pull request
[ FF8 ] Vram bleed into second_chr field objects #759
Closed
@julianxhokaxhiu julianxhokaxhiu merged commit e84f0c4 into julianxhokaxhiu:master Dec 4, 2024
1 check passed
@julianxhokaxhiu
Copy link
Owner

Thank you!

@myst6re myst6re deleted the fix/ff8-external-texture-reload branch December 5, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianxhokaxhiu julianxhokaxhiu julianxhokaxhiu approved these changes

Assignees

@myst6re myst6re

Labels
bug Something isn't working
Projects
None yet
Milestone
1.21.1
Development

Successfully merging this pull request may close these issues.

[ FF8 ] Vram bleed into second_chr field objects
2 participants
@myst6re @julianxhokaxhiu