Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FF8: Fix elevator blending for mods #746 #749

Merged
merged 1 commit into from
Nov 12, 2024
Merged

FF8: Fix elevator blending for mods #746 #749

merged 1 commit into from
Nov 12, 2024

Conversation

myst6re
Copy link
Contributor

@myst6re myst6re commented Nov 10, 2024 •
edited
Loading

Summary

  • Fix elevator blending for mods
  • Fix crash when more_debug option is enabled -> replacing OutputDebugStringA was a bad idea and leaves the game in a undefined state

2024-11-10 22_56_52-Final Fantasy VIII _ FPS_ 30,0

ACKs

  • I have updated the Changelog.md file
  • I did test my code on FF7
  • I did test my code on FF8

@julianxhokaxhiu julianxhokaxhiu added the bug Something isn't working label Nov 10, 2024
@myst6re myst6re marked this pull request as ready for review November 10, 2024 23:20
@julianxhokaxhiu julianxhokaxhiu merged commit 44bc7d3 into julianxhokaxhiu:master Nov 12, 2024
1 check passed
@julianxhokaxhiu
Copy link
Owner

Thank you!

@julianxhokaxhiu julianxhokaxhiu added this to the 1.21.0 milestone Nov 12, 2024
@myst6re myst6re deleted the fix/746 branch November 14, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianxhokaxhiu julianxhokaxhiu julianxhokaxhiu approved these changes

Assignees

@myst6re myst6re

Labels
bug Something isn't working
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.
2 participants
@myst6re @julianxhokaxhiu