Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CI on merge_group events, to allow for GitHub Merge Queue #219

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DilumAluthge
Copy link
Member

No description provided.

@DilumAluthge DilumAluthge marked this pull request as ready for review February 6, 2024 19:23
@DilumAluthge DilumAluthge requested a review from a team as a code owner February 6, 2024 19:23
@IanButterworth
Copy link
Member

What's the need for a merge queue?

@DilumAluthge
Copy link
Member Author

It makes merging things a little easier, because if you have multiple PRs, you don't need to keep clicking the "Update branch" button on all other PRs once you've merged one PR.

@IanButterworth
Copy link
Member

IanButterworth commented Feb 13, 2024

Would that work for the way this package is built? I assumed the human has to run build on the commit being merged in?

If this is about compat bump PRs, I'd just leave them until someone is ready to do a release based on a repo change, rather than a dep one, unless there's a clear reason to push dep changes out.

The reason we generate so much compathelper noise is we're merging the PRs immediately, I think?

@DilumAluthge DilumAluthge marked this pull request as draft June 19, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants