Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiler: improve consistency in julec and julec help #122

Merged
merged 1 commit into from
Jan 11, 2025

Conversation

adamperkowski
Copy link
Member

@adamperkowski adamperkowski commented Jan 11, 2025

changes:
-refactored the code to use the help() instead of hard-coding commands when invoking julec with no arguments
-changed grammar to be more consistent

Signed-off-by: Adam Perkowski adas1per@protonmail.com

@adamperkowski adamperkowski added the compiler Related with comptime or compilation problems label Jan 11, 2025
@adamperkowski adamperkowski force-pushed the adam/compiler/consistency branch from 15625b5 to 91243c6 Compare January 11, 2025 21:24
@adamperkowski adamperkowski changed the title compiler: improve consistency julec and julec help compiler: improve consistency in julec and julec help Jan 11, 2025
@adamperkowski adamperkowski force-pushed the adam/compiler/consistency branch from 91243c6 to 30cdfd3 Compare January 11, 2025 21:25
@adamperkowski
Copy link
Member Author

i'll cancel and rerun the CIs so i won't waste those precious minutes

Copy link
Member

@mertcandav mertcandav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good in general.
But please keep the new-line between commands.

src/julec/main.jule Outdated Show resolved Hide resolved
changes:
-refactored the code to use the `help()` instead of hard-coding commands when invoking `julec` with no arguments
-changed grammar to be more consistent

Co-authored-by: mertcandav <mertcandav@outlook.com>
Signed-off-by: Adam Perkowski <adas1per@protonmail.com>
@adamperkowski adamperkowski force-pushed the adam/compiler/consistency branch from 30cdfd3 to 5e5bb03 Compare January 11, 2025 21:43
Copy link
Member

@mertcandav mertcandav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution.

@mertcandav mertcandav merged commit cf1c7d6 into master Jan 11, 2025
42 checks passed
@adamperkowski adamperkowski deleted the adam/compiler/consistency branch January 11, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler Related with comptime or compilation problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants