Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation updates #397

Merged
merged 1 commit into from
Feb 9, 2024
Merged

documentation updates #397

merged 1 commit into from
Feb 9, 2024

Conversation

hmlanigan
Copy link
Member

Update authentication methods and the list of supported resources and data sources.

The template is combined with the files in examples/provider/ to create: https://registry.terraform.io/providers/juju/juju/latest/docs

JUJU-5405

@hmlanigan hmlanigan added the kind/doc indicates a documentation change label Feb 2, 2024
@hmlanigan hmlanigan requested a review from tmihoc February 2, 2024 21:46

* `$XDG_DATA_HOME/juju`
* `~/.local/share/juju`
### Populated by provider via the juju cli client.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth to also add here that the provider is not dependent on the juju-cli (mostly to avoid future queries about that).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments for the other file.

docs/index.md Outdated
@@ -10,11 +10,24 @@ description: |-

The provider can be used to interact with [Juju][0] - a model-driven Operator Lifecycle Manager (OLM) by Canonical.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the current Juju terminology guidelines, we should drop the "OLM" verbiage.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the replacement? Going with an open source orchestration engine by Canonical. from juju.is for now.

docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
templates/index.md.tmpl Outdated Show resolved Hide resolved
templates/index.md.tmpl Outdated Show resolved Hide resolved

* `$XDG_DATA_HOME/juju`
* `~/.local/share/juju`
### Populated by provider via the juju cli client.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments for the other file.


The intention is to remove this dependency in future.
This is the most straight-forward solution. Remember, that it will use the configuration used by the CLI at that moment. The fields are populated using the output from running the command:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments for this portion in the other file above.

@hmlanigan hmlanigan requested a review from tmihoc February 7, 2024 21:22
Copy link
Member

@tmihoc tmihoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested some typo fixes. Will leave it up to you whether to fix them now or later. They generally boil down to:

  • Use normal language, including all the articles, even in the titles (E..g, "Populated by the provider via the Juju CLI client").
  • Spell "juju" when you mean the juju CLI and "Juju" otherwise.
  • Spell "CLI" with caps.

Other than that, looks good, thanks!

docs/index.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
templates/index.md.tmpl Outdated Show resolved Hide resolved
templates/index.md.tmpl Show resolved Hide resolved
templates/index.md.tmpl Outdated Show resolved Hide resolved
templates/index.md.tmpl Show resolved Hide resolved
templates/index.md.tmpl Outdated Show resolved Hide resolved
@hmlanigan hmlanigan added this to the 0.11.0 milestone Feb 8, 2024
@hmlanigan
Copy link
Member Author

Made the last set of changes and squashed the commits.

Thank you @tmihoc for the detailed review.

@hmlanigan hmlanigan merged commit 572b955 into juju:main Feb 9, 2024
23 checks passed
@hmlanigan hmlanigan deleted the update-index.md branch February 9, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/doc indicates a documentation change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants