Adds install-dependencies target in Makefile #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adds the only dependancy on Terrform snap.
hmlanigan
reviewed
Dec 4, 2023
|
@anvial Could you update the Readme to reflect these changes. |
- adds golangci-lint - adds go
anvial
force-pushed
the
JUJU-5117-add-dependency-target-to-makefile-for-terraform-plugin
branch
from
ae5f6ac to
7e3ca7f
Compare
hmlanigan
approved these changes
Dec 8, 2023
| @@ -34,6 +34,12 @@ _Note:_ These features may not have functional parity with the juju cli at this | |||
|
|
|||
| 1. Clone the repository | |||
| 1. Enter the repository directory | |||
| 1. Build the provider dependencies using the make `install-dependencies` target: | |||
There was a problem hiding this comment.
As we're not actually building the dependencies, suggest:
"Install the provider requirements and dependencies using the make install-dependencies target:"
anvial
deleted the
JUJU-5117-add-dependency-target-to-makefile-for-terraform-plugin
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a new Makefile target, which adds the dependency on snaps listed in the PACKAGES variable.
Here is the list of the packages:
Environment
Juju controller version: any
Terraform version: any
QA steps
Links
Jira-card: JUJU-5117