Remove principal from schema #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmlanigan
force-pushed
the
remove-principal-from-schema
branch
3 times, most recently
from
d38c3e5 to
a8d2e6a
Compare
hmlanigan
force-pushed
the
remove-principal-from-schema
branch
from
a8d2e6a to
98693cc
Compare
It's a value only used by the terraform provider and not the users. Nor does the provide use the value saved, rather it uses the value from a juju api call. Leave the element in the application data structure to allow upgrades of the provider without versionining the schema. That will be done for version 1.0.0
hmlanigan
force-pushed
the
remove-principal-from-schema
branch
from
98693cc to
b3beaab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove unused schema value which cannot be used by a user either. The provider was saving the principal value, but not using it. Rather it was using the Principal value from a juju api response. No need to keep it.
Type of change
QA steps
Deploy an application via a plan with 0.9.1 and upgrade. Deploy another application with the new version of the provider.