GitHub action timeouts #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integration workflow already updated, new tests added for multiple integrations make the tests take longer.
"Error: Custom provider set without credentials:" but I'm not sure why, the only difference with other actions, is this one line.
cderici
approved these changes
Oct 18, 2023
| @@ -70,5 +70,5 @@ jobs: | |||
| - env: | |||
| TF_ACC: "1" | |||
| TEST_CLOUD: ${{ matrix.cloud }} | |||
| run: go test -v -cover ./internal/provider/ | |||
There was a problem hiding this comment.
why's this different than the workflow timeout?
There was a problem hiding this comment.
The other sections can take longer I'd say. They are also timeouts covering different sets of work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The canary and new candidate workflows should have been updated as part of #309, to increase the timeout for the tests.
Attempting to fix the new candidate workflow from failing with
Custom provider set without credentials:, though I'm not sure of the cause.