Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add use-defsrc action #1336

Merged
merged 3 commits into from
Nov 9, 2024
Merged

feat: add use-defsrc action #1336

merged 3 commits into from
Nov 9, 2024

Conversation

jtroo
Copy link
Owner

@jtroo jtroo commented Nov 9, 2024

Describe your changes. Use imperative present tense.

Related to #1255

Potentially a breaking change in case someone has decided to use the string use-defsrc within a deflocalkeys variant. I considered a shorter name like src but that seemed like a higher risk of actually being used within deflocalkeys due to its brevity. Thus the verbose name use-defsrc.

Checklist

  • Add documentation to docs/config.adoc
    • Yes
  • Add example and basic docs to cfg_samples/kanata.kbd
    • Yes
  • Update error messages
    • Yes
  • Added tests, or did manual testing
    • Yes

@jtroo jtroo merged commit 62b2269 into main Nov 9, 2024
4 checks passed
@jtroo jtroo deleted the usedefsrc branch November 9, 2024 08:10
eugenesvk pushed a commit to eugenesvk/kanata that referenced this pull request Jan 17, 2025
Potentially a breaking change in case someone has decided to use the
string `use-defsrc` within a `deflocalkeys` variant. I considered a
shorter name like `src` but that seemed like a higher risk of actually
being used within `deflocalkeys` due to its brevity. Thus the verbose
name `use-defsrc`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant