Added Mile and International Nautical Mile

src/Geodesy/Distance/BaseDistance.php

@@ -5,6 +5,8 @@
 use Geodesy\Location\LatLong;
 use Geodesy\Unit\UnitInterface;
 use Geodesy\Unit\Metre;
+use Geodesy\Unit\Mile;
+use Geodesy\Unit\KiloMetre;
 
 abstract class BaseDistance
 {
@@ -22,7 +24,7 @@ public function __construct(LatLong $source, LatLong $destination)
         $this->source = $source;
         $this->destination = $destination;
         $this->radius = self::R;
-        $this->unit = null;
+        $this->unit = new KiloMetre;
     }
 
     public function setUnit(UnitInterface $unit)
@@ -37,22 +39,14 @@ public function getUnit()
 
     public function getDistance()
     {
-        $dist = $this->distance();
-        if($this->getUnit() instanceof Metre){
-            $dist = $dist * 1000;
-         }
-        $this->unit->setValue($dist);
-        return $this->unit->getValue();
+        return $this->getUnit()->convert($this->distance());
     }
 
     abstract public function distance();
 
     public function isInRange($range)
     {
-        if($this->getUnit() instanceof Metre){
-            $range = $range * 1000;
-         }
-        return $this->getDistance() <= $range;
+        return $this->getDistance() <= $this->getUnit()->convert($range);
     }
 
 }

src/Geodesy/Distance/HaversineFormula.php

@@ -3,9 +3,6 @@
 namespace Geodesy\Distance;
 
 use Geodesy\Location\LatLong;
-use Geodesy\Unit\KiloMetre;
-use Geodesy\Unit\Metre;
-
 
 class HaversineFormula extends BaseDistance implements DistanceInterface
 {
@@ -14,7 +11,6 @@ class HaversineFormula extends BaseDistance implements DistanceInterface
     public function __construct(LatLong $source, LatLong $destination)
     {
         parent::__construct($source, $destination);
-        $this->unit = new Kilometre;
     }
 
     /**

src/Geodesy/Distance/SphericalCosine.php

@@ -3,16 +3,13 @@
 namespace Geodesy\Distance;
 
 use Geodesy\Location\LatLong;
-use Geodesy\Unit\KiloMetre;
-use Geodesy\Unit\Metre;
 
 class SphericalCosine extends BaseDistance implements DistanceInterface
 {
 
     public function __construct(LatLong $source, LatLong $destination)
     {
         parent::__construct($source, $destination);
-        $this->unit = new Kilometre;
     }
 
     /**

src/Geodesy/Distance/VincentyFormula.php

@@ -3,16 +3,13 @@
 namespace Geodesy\Distance;
 
 use Geodesy\Location\LatLong;
-use Geodesy\Unit\Metre;
-use Geodesy\Unit\KiloMetre;
 
 class VincentyFormula extends BaseDistance implements DistanceInterface
 {
 
     public function __construct(LatLong $source, LatLong $destination)
     {
         parent::__construct($source, $destination);
-        $this->unit = new KiloMetre;
     }
 
     /**

src/Geodesy/Unit/BaseUnit.php

@@ -3,25 +3,9 @@
 namespace Geodesy\Unit;
 
 
-class BaseUnit
+abstract class BaseUnit
 {
 
-    protected $value;
-
-    public function __construct()
-    {
-        $this->value = null;
-    }
-
-    public function setValue($value)
-    {
-        $this->value = $value;
-    }
-
-    public function getValue()
-    {
-        return $this->value;
-    }
-
+    abstract public function convert($value);
 
 }

src/Geodesy/Unit/KiloMetre.php

@@ -6,5 +6,10 @@
 class KiloMetre extends BaseUnit implements UnitInterface
 {
 
+	// This is our base unit, so just return it
+    public function convert($value)
+    {
+        return $value;
+    }
 
 }

src/Geodesy/Unit/Metre.php

@@ -6,5 +6,9 @@
 class Metre extends BaseUnit implements UnitInterface
 {
 
+    public function convert($value)
+    {
+        return $value * 1000;
+    }
 
 }

src/Geodesy/Unit/Mile.php

@@ -0,0 +1,14 @@
+<?php
+
+namespace Geodesy\Unit;
+
+
+class Mile extends BaseUnit implements UnitInterface
+{
+
+    public function convert($value)
+    {
+        return $value * 0.62137;
+    }
+
+}

src/Geodesy/Unit/NauticalMile.php

@@ -0,0 +1,14 @@
+<?php
+
+namespace Geodesy\Unit;
+
+
+class NauticalMile extends BaseUnit implements UnitInterface
+{
+
+    public function convert($value)
+    {
+        return $value * 0.539957;
+    }
+
+}