Making stimulus-swipe-container drag with stimulus div #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a7fb39d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Hello, can I please get this review? |
|
Sorry for the delay. Looks like a test is failing now. Maybe it just needs to be updated? |
|
I tested locally. I hope they pass now |
|
Hi @Emily-ejag It looks like there is one test that is failing sometimes in the simulation part of the code. This might be failing randomly due to different random data generation in the simulation data? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch ensures that both the container (
#jspsych-html-swipe-response-stimulus-container) and the stimulus (#jspsych-html-swipe-response-stimulus) move together when dragged, providing a unified and seamless interaction.