-
-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add default mimeType
if none is specified
#3495
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 54a9014 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@jadeddelta I think we might need to add a codec part to the string. See lookit/lookit-jspsych#127 (comment). @becky-gilbert do you think we should use something like your function that gets compatible mime types? |
@jodeleeuw @jadeddelta sorry for the slow response. Yes you could definitely use the Or you could stick with a single default option, it just depends on the breadth of browser/versions you want to support. The important thing is to make sure to specify a We're using webm, and "video/webm;codecs=vp9,opus" would work for recent versions of the most popular browsers. But that won't work on Safari. Another good option is mp4: "video/mp4; codecs="avc1.42E01E, mp4a.40.2" (I can't remember why we didn't use this before - I think it wasn't available in Chrome before but looks like it is now?). |
LGTM! But one more change that you might want to include is the |
this PR closes #3494, allowing for
initializeCameraRecorder()
to search for a valid container/codec combination if amimeType
is not provided, defaulting to'video/webm'
if none are found. also updating the docs to reflect this change