Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add real-time value display feature to plugin-html-slider-response #3372

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

raynatang
Copy link

Added real-time value display feature to plugin-html-slider-response: if the parameter value_display is set as true, the slider's value will be displayed in real-time below the slider as participants adjust it.

Before participants adjust the slider, the displayed value will be the slider_start value

Added real-time value display feature to plugin-html-slider-response: if the parameter value_display is set as true, the slider's value will be displayed in real-time below the slider as participants adjust it. 

Before participants adjust the slider, the displayed value will be the slider_start value
Copy link

changeset-bot bot commented Aug 10, 2024

⚠️ No Changeset found

Latest commit: 50de647

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jodeleeuw
Copy link
Member

Hi @raynatang,

Thanks for the PR!

I think this is worth adding. A few things that would be needed before we can merge:

  1. I think one PR that includes updates to all the *-slider-response plugins would be ideal.
  2. I think making the default display false instead of true, so that existing experiments are unaffected by the update.
  3. Changes to the corresponding documentation files.

If you're willing to work on any of that - great!

@raynatang
Copy link
Author

Thank you! I'll work on them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants