Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle permission rejection from camera/microphone #2847

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jadeddelta
Copy link
Collaborator

hi all, this PR is made in regards to #2522, by adding a warning message for those who try to initialize the html-video-response or html-audio-response plugins. along with this, the initialize-camera and initialize-microphone plugins now allow the user to give a custom rejection message if the participant rejects the use of the camera/microphone.

IMPORTANT TO NOTE: for some reason, the initialize-camera plugin does not play well with camera rejection, and will not display the rejection message. was wondering if this was only the case on my machine, or on others too because the code i used for both rejection mechanisms are the same.

@changeset-bot
Copy link

changeset-bot bot commented Nov 1, 2022

🦋 Changeset detected

Latest commit: 820abb0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@jspsych/plugin-html-audio-response Patch
@jspsych/plugin-html-video-response Patch
@jspsych/plugin-initialize-microphone Minor
@jspsych/plugin-initialize-camera Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant