-
-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add slider keyboard functionality #2827
base: main
Are you sure you want to change the base?
Conversation
|
🎉 what about using |
@jodeleeuw all done! interesting thing to note though is i had to use |
Hmm it should be possible to use one listener and register only the set of valid keys. What error was being generated? |
Just one thing to flag is that it is not entirely clear to me how the 'panning' would work. Using the jsfiddle example from #2570, it's unclear to me why the keys 3 and 5 pressed in succession should lock to 30 and 50, instead of 35. The |
Going to pick this back up - current proposal for functionality I think covers most use cases (incl. key_panning issue): https://jsfiddle.net/fk1h45vp/41/ (repo). Will add to -contrib first, lmk if suggestions on above! |
Hi all, this PR was made from the suggestion in #2570, by adding three fields
enable_keys
,keys_adjust
, andkeys_panning
in order to allow a participant to use the keyboard to pan through a slider.This is a draft for now as I'd like to make sure that everything looks good before I can potentially add this functionality to the rest of the slider response plugins.