Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hide_slider_while_playing parameter #2360

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gali1998
Copy link
Contributor

With this option it is now possible to hide the slider while the video is playing.
This feature has been requested by my team for one of our experiments, and I hope it can be added to this plugin for our future experiments.

Please let me know if there is anything else I can do to help make it happen.

Thank you in advance,
Gali Geller

@changeset-bot
Copy link

changeset-bot bot commented Nov 27, 2021

⚠️ No Changeset found

Latest commit: 0f7cc03

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

With this option it is now possible to hide the slider while the video is playing
@gali1998 gali1998 force-pushed the hide-slider-while-video-playing branch from 1a01f67 to 3f23fe5 Compare November 27, 2021 18:41
@jodeleeuw
Copy link
Member

Thanks @gali1998 !

One quick idea and one request:

  1. What about naming the parameter hide_slider_while_playing to be consistent with response_allowed_while_playing?
  2. Would you be willing to implement this in the audio_slider_response plugin as well?

@jodeleeuw
Copy link
Member

One more thought: I wonder if the button should hide too when the slider is hidden?

@gali1998
Copy link
Contributor Author

Hi @jodeleeuw !
I have already changed the name of the parameter- I will commit it as soon as Github will let me (they seem to have some technical challenges at the moment).
I will add it to the audio plugin as well- this might take me a bit of time.

About the button- this actually came up in our lab meeting as well.
My team thinks the slider is quite distracting, which is why they asked me to remove it while the video is playing. They said that they don't mind the button for now, which is why I haven't removed it yet.

The question is, are the slider and the button always related? I am thinking about a situation where there's a video playing, and the participant can either watch it all (and then rate using the slider), or skip. If I were to conduct an experiment like that I guess it would have been useful to me if the slider and the button weren't attached.

Let me know what you think,

Gali

@jodeleeuw jodeleeuw changed the title Added a new option to the plugin Add hide_slider_while_playing parameter Nov 28, 2021
@jodeleeuw
Copy link
Member

The question is, are the slider and the button always related? I am thinking about a situation where there's a video playing, and the participant can either watch it all (and then rate using the slider), or skip. If I were to conduct an experiment like that I guess it would have been useful to me if the slider and the button weren't attached.

This makes sense, but I don't think is something that the plugin really supports yet. In the current implementation any response with the button will measure the slider value and add it to the data. Given the lack of a skip feature right now, I think hiding the button with the slider makes sense. I also think the skip feature would be used by researchers less often than the hiding slider feature, so it makes sense as a default option to hide the button when the slider is hidden.

@gali1998
Copy link
Contributor Author

gali1998 commented Dec 6, 2021

Hi,
Sorry it took me so long- I have hidden the continue button as well, and added the change to the audio slider response plugin as well.

Gali

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants