Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix Azure DevOps authentication for personal Microsoft accounts #1

Merged
merged 3 commits into from
Aug 25, 2024

Conversation

jslorrma
Copy link
Owner

Context

For Azure DevOps organizations linked to a personal Microsoft account, AzureCLiCredential does not work.

Changes

  • Implemented a check to determine if an Azure DevOps organization is linked to a personal account.
  • The check involves making a plain request to the Azure DevOps organization PyPI simple URL.
  • If the request returns only basic auth authentication in the header or the returned tenant_id ("X-VSS-ResourceTenant") is 00000000-0000-0000-0000-000000000000 in the return header, it indicates a personal Microsoft account.

This fix ensures that the correct authentication method is used for Azure DevOps organizations linked to personal Microsoft accounts.

The  changes in `README.md` update the description:
- of the `keyrings.artifacts` package to explicitly mention that it leverages the `azure-identity` library for authentication.
- of the system-wide keyring installation adding a note, that pixi global install is not possible yet
- Context: For Azure DevOps organizations linked to a personal Microsoft account, `AzureCLiCredential` does not work.
- Implemented a check to determine if an Azure DevOps organization is linked to a personal account.
- The check involves making a plain request to the Azure DevOps organization PyPI simple URL.
- If the request returns only basic auth authentication in the header or the returned tenant_id (`X-VSS-ResourceTenant`) is `00000000-0000-0000-0000-000000000000` in return header, it indicates a personal Microsoft account.
@jslorrma jslorrma merged commit a86110a into main Aug 25, 2024
10 checks passed
@jslorrma jslorrma deleted the feature/handle-private-accounts branch August 25, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant