Code

Fix (some) linter findings#190

Code

Merged

ugol merged 23 commits intojrnd-io:mainjrnd-io/jr:mainfrom lburgazzoli:lintlburgazzoli/jr:lintCopy head branch name to clipboardAug 23, 2024

+409-382

Commits

Commits on Aug 23, 2024

• chore(lint): configure make lint target to use .localci/lint/golangci.yml

  lburgazzoli

  committed
  20dac5d

  Copy full SHA for 20dac5d

• fix(lint/copylocks): assignment copies lock value

  lburgazzoli

  committed
  839eeae

  Copy full SHA for 839eeae

• fix(lint/staticcheck): should not use built-in type string as key for context value

  lburgazzoli

  committed
  57e6e3e

  Copy full SHA for 57e6e3e

• fix(lint/staticcheck): printf-style function with dynamic format string and no further arguments should use print-style function instead

  lburgazzoli

  committed
  4283896

  Copy full SHA for 4283896

• fix(lint/staticcheck): this value of is never used

  lburgazzoli

  committed
  37d1982

  Copy full SHA for 37d1982

• fix(lint/gosimple): should omit nil check; len() for []byte is defined as zero

  lburgazzoli

  committed
  3a01dfe

  Copy full SHA for 3a01dfe

• fix(lint/gosimple): should use b.Bytes() instead of []byte(b.String())

  lburgazzoli

  committed
  0d5b435

  Copy full SHA for 0d5b435

• fix(lint/gosimple): should merge variable declaration with assignment on next line

  lburgazzoli

  committed
  e01033d

  Copy full SHA for e01033d

• fix(lint/gosimple): unnecessary assignment to the blank identifier

  lburgazzoli

  committed
  6fd0b01

  Copy full SHA for 6fd0b01

• fix(lint/errcheck): error return value not checked

  lburgazzoli

  committed
  7e923d4

  Copy full SHA for 7e923d4

• fix(lint/copyloopvar): the copy of the 'for' variable can be deleted (Go 1.22+)

  lburgazzoli

  committed
  d609078

  Copy full SHA for d609078

• fix(lint/unconvert): unnecessary conversion

  lburgazzoli

  committed
  14a4e3a

  Copy full SHA for 14a4e3a

• fix(lint/revive): fix exported type to remove package prefix duplication

  lburgazzoli

  committed
  3a95afd

  Copy full SHA for 3a95afd

• fix(lint/revive): if block ends with a return statement, so drop this else and outdent its block

  lburgazzoli

  committed
  11404cd

  Copy full SHA for 11404cd

• fix(lint/revive): if block ends with call to os.Exit function, so drop this else and outdent its block

  lburgazzoli

  committed
  73c9a8f

  Copy full SHA for 73c9a8f

• fix(lint/wastedassign): assigned but reassigned without using the value

  lburgazzoli

  committed
  01f4d79

  Copy full SHA for 01f4d79

• fix(lint/stylecheck): should use constant http.StatusMovedPermanently instead of numeric literal 301

  lburgazzoli

  committed
  01c1e4f

  Copy full SHA for 01c1e4f

• fix(lint/contextcheck): functions should pass the context parameter

  lburgazzoli

  committed
  98305a2

  Copy full SHA for 98305a2

• fix(lint/gosec): slice index out of range

  lburgazzoli

  committed
  3efaa4a

  Copy full SHA for 3efaa4a

• fix(lint/nestif): complex nested blocks

  lburgazzoli

  committed
  d2377c5

  Copy full SHA for d2377c5

• fix(lint/gosec): use of net/http serve function that has no support for setting timeouts

  lburgazzoli

  committed
  eee0cc5

  Copy full SHA for eee0cc5

• fix(lint/gocritic): rewrite if-else to switch statement

  lburgazzoli

  committed
  9e8a907

  Copy full SHA for 9e8a907

• fix(lint/revive): don't use MixedCaps in package name; mongoDB should be mongodb

  lburgazzoli

  committed
  81ccde1

  Copy full SHA for 81ccde1