Topic/jrl qp #26
Open
Topic/jrl qp #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gergondet
requested changes
May 20, 2021
| ################### | ||
| # - jrl-qp - # | ||
| ################### | ||
| option(TVM_WITH_JRLQP "Build with Quadprog support" OFF) |
| class TVM_DLLAPI JRLQPLSSolverFactory : public abstract::LSSolverFactory | ||
| { | ||
| public: | ||
| std::unique_ptr<abstract::LSSolverFactory> clone() const override; |
There was a problem hiding this comment.
clone can return std::unique_ptr<JRLQPLSSolverFactory>
| @@ -16,7 +16,7 @@ public: \ | |||
| } | |||
|
|
|||
| /** Adding an option \a optionName of type \a type with no default value. | |||
| * (The default value of the underlying solver will be used. | |||
| * The default value of the underlying solver will be used. | |||
| */ | |||
| #define TVM_ADD_DEFAULT_OPTION(optionName, type) \ | |||
There was a problem hiding this comment.
This is not related to this PR but why do TVM_ADD_NON_DEFAULT_OPTION still store things as std::optional<T> when there's no way for them not to hold a value?
Comment on lines
+20
to
+24
| TVM_PROCESS_OPTION(maxIter, options_); | ||
| TVM_PROCESS_OPTION(warmStart, options_); | ||
| TVM_PROCESS_OPTION(logFlags, options_); | ||
| if(options.logStream()) | ||
| options_.logStream(*options.logStream().value()); |
There was a problem hiding this comment.
Couldn't we simplify this by having a jrl::qp::SolverOptions field in JRLQPLSSolverOptions?
There was a problem hiding this comment.
And why separate big_number and bigBnd from jrl::qp::SolverOptions which are the same things afaik?
Comment on lines
+182
to
+185
| if(impact.equalityConstraints_) | ||
| impact.inequalityConstraints_ = true; | ||
| if(impact.inequalityConstraints_) | ||
| impact.equalityConstraints_ = true; |
There was a problem hiding this comment.
impact.equalityConstraints_ |= impact.inequalityConstraints_;
impact.inequalityConstraints_ = impact.equalityConstraints_;(generates branchless code godbolt)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds supports for the Goldfarb-Idnani solver from
jrl-qp(with the latest improvements from the branch topic/BlockStructure - waiting for me to clean it and merge it into master).Nothing special here, the solver wrapping is a mix between
LSSOLLeastSquareSolverandQuadprogLeastSquareSolver.