This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Add more thorough tests for jQuery UI 1.12.1 & 1.13.2 #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgol
commented
Apr 7, 2024
| @@ -1,5 +1,5 @@ | |||
| /*! | |||
| * jQuery UI CSS Framework @VERSION | |||
| * jQuery UI CSS Framework 1.12.1 | |||
There was a problem hiding this comment.
For the fixtures, I just took base/theme.css from https://github.com/jquery/jquery-ui/blob/1.13.2/themes/base/theme.css and themes/smoothness.css from a proper bundle from https://jqueryui.com/download/. The only change I had to make in that latter file is updating the URL after "To view and modify this theme, visit ..." since it's not stable.
I did the same for 1.12.1.
mgol
commented
Apr 7, 2024
|
|
||
| theme = new ThemeRoller( baseThemeCss, vars ); | ||
| } ); | ||
| [ "1.12.1", "1.13.2" ].forEach( ( jQueryUiVersion ) => { |
There was a problem hiding this comment.
This one is the main file to review. I recommend reviewing with whitespace changes turned off due to the change in indentation.
timmywil
approved these changes
Apr 8, 2024
Closed
mgol
added a commit
to mgol/download.jqueryui.com
that referenced
this pull request
Apr 19, 2024
mgol
added a commit
to mgol/download.jqueryui.com
that referenced
this pull request
Apr 19, 2024
mgol
added a commit
to mgol/download.jqueryui.com
that referenced
this pull request
Apr 19, 2024
mgol
added a commit
to mgol/download.jqueryui.com
that referenced
this pull request
Apr 21, 2024
mgol
added a commit
to jquery/download.jqueryui.com
that referenced
this pull request
Apr 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.