feat: babel rewrite dependency detection with scopes #561
+572
−1,043
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a big rewrite of Babel dependency detection, this time it's based on Scopes instead of node traversing.
It should work for all patterns, but won't support three cases:
function
keyword, you need to either use arrow function or object (style or dynamic function)To merge it I need to:
screen
from Mini Runtime not updating properly in StyleSheet #558 and [v3] nested block statements in dynamic functions #454