Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate pyfilesystem backend? #238

Open
1 of 3 tasks
timkpaine opened this issue Feb 18, 2025 · 4 comments
Open
1 of 3 tasks

Deprecate pyfilesystem backend? #238

timkpaine opened this issue Feb 18, 2025 · 4 comments
Labels
type: enhancement Minor improvements

Comments

@timkpaine
Copy link
Collaborator

Such a deprecation plan would require:

  • fsspec Localfilesystem replaces pyfilesystem osfs this appears to already be the case
  • s3fs replaces pyfilesystem fs-s3fs - testing but its looking good
  • fsspec smb replaces fs.smbfs - this has historically been the difficulty
@timkpaine timkpaine added the type: enhancement Minor improvements label Feb 18, 2025
@timkpaine timkpaine changed the title Deprecate pyfilesystem? Deprecate pyfilesystem backend Feb 18, 2025
@tharwan
Copy link

tharwan commented Feb 19, 2025

Is it already possible to configure jupyter-fs to use fsspec for smb? I could not quite tell from the readme but I am happy to try it in our setup and help stabilise it.

@timkpaine timkpaine changed the title Deprecate pyfilesystem backend Deprecate pyfilesystem backend? Feb 20, 2025
@vidartf
Copy link
Contributor

vidartf commented Feb 21, 2025

A major improvement that can be made to the fsspec SMB code would be to have it rely on the smbclient.scandir call (at least when detail=True is passed to fsspec's .listdir method). Then it wouldn't need to do a stat call per directory entry in listdir, which can be very expensive in terms of number of network requests. But at least that can be patched in locally, and the current behavior matches that of PyFilesystem, so I'm mentioning it more as an FYI rather than something that should block this issue.

@vidartf
Copy link
Contributor

vidartf commented Feb 21, 2025

Ah, I got distracted, I meant to ask what the issue is with the fsspec smb client implementation, as you mentioned that as a requirement.

@timkpaine
Copy link
Collaborator Author

Ah, I got distracted, I meant to ask what the issue is with the fsspec smb client implementation, as you mentioned that as a requirement.

I honestly dont remember at this point but i very vaguely recall @telamonian looking into it and there being some problem. I plan on testing shortly, I'm hoping to make our integration tests against smb and s3 parameterized by both pyfilesystem and fsspec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Minor improvements
Projects
None yet
Development

No branches or pull requests

3 participants