Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for AlbumUtils private constructor and formatYear method #90

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

Lemeri123
Copy link
Collaborator

This pull request adds unit tests for the AlbumUtils class.

1.Added test for formatYear method:

  • Tests the formatYear method with a valid date string.
  • Tests the formatYear method with an invalid date string and expects a StringIndexOutOfBoundsException.

2.Added test for private constructor:

  • Uses reflection to access the private constructor of the AlbumUtils class.
  • Ensures that the private constructor throws an IllegalStateException.

Copy link
Owner

@josdem josdem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just small changes before merge @Lemeri123 I appreciate your effort.

@josdem
Copy link
Owner

josdem commented Feb 4, 2025

Quality Gate Passed Quality Gate passed

Issues 5 New issues 0 Accepted issues

Measures 0 Security Hotspots 0.0% Coverage on New Code 0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Lemeri123 Also please address these issues reported by SonarCloud before merge.

Copy link

sonarqubecloud bot commented Feb 4, 2025

@Lemeri123 Lemeri123 requested a review from josdem February 4, 2025 23:14
Copy link
Owner

@josdem josdem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing suggested changes, with my comments I am looking to improve your skills as developer.

@Lemeri123
Copy link
Collaborator Author

Thank you so much @josdem I really appreciate

@josdem josdem merged commit e674e02 into main Feb 5, 2025
3 checks passed
@Lemeri123 Lemeri123 deleted the feature/81 branch February 5, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants