Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for AlbumUtils #88

Closed
wants to merge 1 commit into from
Closed

Conversation

Lemeri123
Copy link
Collaborator

Screenshot from 2025-02-04 12-06-27

Copy link

sonarqubecloud bot commented Feb 4, 2025

@Lemeri123
Copy link
Collaborator Author

@josdem how do i resolve the failing test related to sonar. And will it affect the project if its merged

@josdem
Copy link
Owner

josdem commented Feb 4, 2025

@josdem how do i resolve the failing test related to sonar. And will it affect the project if its merged

Hi @Lemeri123 in order to avoid failing tests on PR you should create a branch directly from this repository: git@github.com:josdem/jmetadata.git you are able to do that since you are a collaborator.

@Lemeri123
Copy link
Collaborator Author

Thanks @josdem . Am done. So meaning as for this pull request there is no way of resolving it right??

@josdem
Copy link
Owner

josdem commented Feb 4, 2025

Thanks @josdem . Am done. So meaning as for this pull request there is no way of resolving it right??

This are the steps to solve this issue:

  1. Clone this repository in your local with this command: git clone git@github.com:josdem/jmetadata.git
  2. Create a feature branch with this command: git checkout -b feature/81
  3. Add your src/test/java/com/josdem/jmetadata/util/AlbumUtilsTest.java file
  4. Commit your changes with a meaningful description
  5. Push your changes and create a PR.
    Let me know if any questions.

@josdem
Copy link
Owner

josdem commented Feb 5, 2025

We will close this PR in favor of : #90

@josdem josdem closed this Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants