Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[small]Feature/57 #61

Merged
merged 4 commits into from
Jan 5, 2025
Merged

[small]Feature/57 #61

merged 4 commits into from
Jan 5, 2025

Conversation

josdem
Copy link
Owner

@josdem josdem commented Jan 5, 2025

  • Adding Jacoco configuration
  • Deleting flaky test
  • Updating version

Screenshot
jmetadata

@josdem josdem requested review from pacher and Lemeri123 January 5, 2025 14:48
Copy link
Collaborator

@Lemeri123 Lemeri123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering if it is necessary to update the code to read the key and secret values dynamically

@josdem
Copy link
Owner Author

josdem commented Jan 5, 2025

I was wondering if it is necessary to update the code to read the key and secret values dynamically

Hi @Lemeri123, it is a good call, I tried to do that in our previous release with no success, let's create a Spike task to address this inprovement though.

@josdem
Copy link
Owner Author

josdem commented Jan 5, 2025

I was wondering if it is necessary to update the code to read the key and secret values dynamically

Hi @Lemeri123, it is a good call, I tried to do that in our previous release with no success, let's create a Spike task to address this inprovement though.

Here we go: #62

@josdem josdem merged commit a803b7a into main Jan 5, 2025
1 check passed
@josdem josdem mentioned this pull request Jan 5, 2025
@Lemeri123
Copy link
Collaborator

I was wondering if it is necessary to update the code to read the key and secret values dynamically

Hi @Lemeri123, it is a good call, I tried to do that in our previous release with no success, let's create a Spike task to address this inprovement though.

Here we go: #62

Alright thats really great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants