-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add label tip for Base URL settings fields #1391
Add label tip for Base URL settings fields #1391
Conversation
180126f
to
acf6afa
Compare
lol 🤦 I force-pushed because the label text I added was the opposite of what it should have been |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is still showing as must have, instead of must NOT have.
Also, I believe it would be better if it simply said No Leading Slash
. Since it is implied its information for the Base URL setting, due to the position.
acf6afa
to
6d4c951
Compare
@ydkmlt84 Made the requested changes! Not sure what happened with my first force-push ¯\_(ツ)_/¯ |
Wouldn't it be better for the server-side logic to check for a leading slash and remove it if present? |
@jorenn92 Definitely would be better for the server to do it! There was some discussion in the issue I created and adding a label seemed like a decent interim solution that I could readily handle myself. Not sure how much more involved it would be to properly handle on the back end. |
6d4c951
to
e5491fa
Compare
Oh, I see! I missed that issue. I didn’t realize this was just a temporary solution. In that case, it works for me. |
e5491fa
to
126ac26
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Adds label tips for Base URL fields! Simple fix for #1390
Screenshot
![CleanShot 2024-11-20 at 11 29 09](https://private-user-images.githubusercontent.com/172217/388202546-3c85ada0-0839-4034-836f-1d0cff4f3f39.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1ODc1NzUsIm5iZiI6MTczOTU4NzI3NSwicGF0aCI6Ii8xNzIyMTcvMzg4MjAyNTQ2LTNjODVhZGEwLTA4MzktNDAzNC04MzZmLTFkMGNmZjRmM2YzOS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE1JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNVQwMjQxMTVaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT05ZDdlZjJiMjgyYzU4N2JjNDIzY2NhNzA5ZGRmNWE2NWIzM2Q3Mjk4MzgzZjg0NDBhYjBjOWZkZmQ4OGQ2Y2RjJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.B5lTo5IgQYaZnZQiCBPLPGo-f127dPBgqOpifla5iMY)