Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring - improving coverage #371

Open
wants to merge 6 commits into
base: refactoring
Choose a base branch
from

Conversation

bluntelk
Copy link

I have started writing some unit tests to improve coverage of the refactoring.

This PR should bring coverage of the acmedns package up to 100%

* More testing of ReadConfig() and its fallback mechanism

* Found that if someone put a '"' double quote into the filename that we configure zap to log to, it would cause the the JSON created to be invalid. I have replaced the JSON string with proper config
…valid value instead of silently failing.

added a basic test for api.setupTLS() (to increase test coverage)
@bluntelk bluntelk mentioned this pull request Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant