Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #79 - Use plexus to support classpath resources #80

Conversation

pwhittlesea
Copy link
Contributor

@pwhittlesea pwhittlesea commented May 10, 2024

Fixes #79

The code here is inspired by the PMD maven plugin
https://github.com/apache/maven-pmd-plugin/blob/4afad98d229a6764d2ebdd246c037d1645c7cbb9/src/main/java/org/apache/maven/plugins/pmd/PmdReport.java#L394

The aim is to support classpath configuration when using this plugin in parent aggregator projects where config is in a plugin dependency.

@pwhittlesea pwhittlesea changed the title Fix #79: Use plexus to support classpath resources Fix #79 - Use plexus to support classpath resources May 10, 2024
@jonathanlermitage jonathanlermitage self-requested a review May 10, 2024 20:22
This is inspired by the PMD maven plugin
https://github.com/apache/maven-pmd-plugin/blob/4afad98d229a6764d2ebdd246c037d1645c7cbb9/src/main/java/org/apache/maven/plugins/pmd/PmdReport.java#L394

The aim is to support classpath configuration when using this plugin in parent aggregator projects where config is in a plugin dependency
@pwhittlesea pwhittlesea force-pushed the feature/support-classpath-resources branch from 4a61d87 to 53c60b0 Compare May 12, 2024 20:14
@pwhittlesea pwhittlesea marked this pull request as ready for review May 12, 2024 20:21
@pwhittlesea
Copy link
Contributor Author

@jonathanlermitage The tests are passing locally for me but I'm not sure why they are failing here. Is there a way to pull the Maven log.txt files to see what happened?

@pwhittlesea
Copy link
Contributor Author

@jonathanlermitage The tests are passing locally for me but I'm not sure why they are failing here. Is there a way to pull the Maven log.txt files to see what happened?

Figured it out 😄

@pwhittlesea pwhittlesea force-pushed the feature/support-classpath-resources branch from 2ad7f56 to ce35df4 Compare May 13, 2024 08:09
@jonathanlermitage
Copy link
Owner

jonathanlermitage commented May 14, 2024

Thanks!
Will try to publish a new release next week.

@jonathanlermitage jonathanlermitage merged commit 6309df9 into jonathanlermitage:master May 14, 2024
3 checks passed
@pwhittlesea pwhittlesea deleted the feature/support-classpath-resources branch May 15, 2024 08:30
@jonathanlermitage
Copy link
Owner

jonathanlermitage commented May 18, 2024

Hum, Maven makes some resistance, again 😅 I will try to publish the new 1.9.0 release asap.
I used to deploy by running:

mvn clean release:prepare
mvn release:perform -P ossrh

(my ossrh maven profile is configured with my Sonatype creds, and my gpg passphrase)
but the second command fails saying

[INFO] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-deploy-plugin:3.1.1:deploy (default-deploy) on project oga-maven-plugin: Deployment failed: repository element was not specified in the POM inside distributionManagement element or in -DaltDeploymentRepository=id::url parameter -> [Help 1]

It will simply take some time...

Nota: I received a Notice of Changes to OSSRH (Sonatype) Account Management. I will look at this.

Edit: okayyyy, I can't login to Nexus, and changing my password doesn't work... I will contact their support team.

@pwhittlesea
Copy link
Contributor Author

Ooh that sounds rough @jonathanlermitage. I'm going to guess that because it's login related there is not much I can do to help, but if there is let me know!

Good luck!

@jonathanlermitage
Copy link
Owner

jonathanlermitage commented May 23, 2024

Thx! The Sonatype support helped me a lot. I just published the 1.9.2 release (strictly identical to 1.9.0) with success. It should be available in Central very soon. 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for classpath resources for definitions and ignore lists
2 participants