-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added skip unitialized values context param #200
Conversation
faae1d6
to
33a4325
Compare
Hello, sorry for the late testing phase 😁 PR need a rebase to fix:
But apart of this error, everything work like a charm, thanks ! |
40a1153
to
954f1d7
Compare
29b78ff
to
fb4a2cc
Compare
I rebased the PR @TheoD02. But I'm kinda blocked with this pull request, in one of the test (see Here is the issue: https://3v4l.org/BsDTZ |
Hello thanks for your answer, maybe we can do something like in PropertyAccessor ? Not really checked the possibility in your implementation |
After talking with @lyrixx he gave me the same thing that PropertyAccess does use: https://3v4l.org/idiOR |
ae31055
to
97d6a64
Compare
97d6a64
to
c6831e9
Compare
@TheoD02 the issue is now fixed, if you want to test again / review that PR ! |
I'll will check this evening, or tomorrow 😀 |
Any news @TheoD02 ? |
Sorry, didn't have time to test it :/ Just updated and runned some tests, and no regression identified on my project, seem to be good ! 😄 |
c6831e9
to
4c2f6a8
Compare
Fixes #189