Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect the "Play repeats" property of D.C. and D.S. [FEATURE] #122

Open
johentsch opened this issue Nov 25, 2024 · 0 comments
Open

Respect the "Play repeats" property of D.C. and D.S. [FEATURE] #122

johentsch opened this issue Nov 25, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@johentsch
Copy link
Owner

johentsch commented Nov 25, 2024

Is your feature request related to a problem? Please describe.

Currently the unfolded versions cannot distinguish between the two settings and defaults to ignoring repeats after a da capo or dal segno jump.

Describe the solution you'd like

The information whether the Play repeats property of a D.S. or D.C. sign is checked the inspector should be stored in an additional column of measure tables. If yes, the unfolding should repeat repeated sections once again. This should probably be reflected in the next column, too.

Implementation details

When checked, the respective <Jump> tag has an additional child <playRepeats>1</playRepeats>.

Example where this is relevant

ABC/n13op130_06 (see DCMLab/ABC#56 )

@johentsch johentsch added the enhancement New feature or request label Nov 25, 2024
@johentsch johentsch self-assigned this Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant