Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HSC 2x2pt pipeline #114

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

git-sunao
Copy link

The pipeline for HSC 2x2pt analysis has been added and validated by me and Tianqing. Here the HSC 2x2pt analysis is the joint analysis of galaxy clustering ($w_{\rm p}$) and galaxy-galaxy lensing ($\Delta\Sigma$).

@git-sunao git-sunao changed the title Hsc2x2pt dev HSC 2x2pt pipeline Dec 12, 2023
likelihood/2pt/2pt_like.py Outdated Show resolved Hide resolved
shear/meascorr/temp.fits Outdated Show resolved Hide resolved
shear/meascorr/temp.txt Outdated Show resolved Hide resolved
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this module replicates the existing module in background/astropy_background/astropy_background.py - is that right? Although yours is probably slightly better as you don't have to choose the model in the setup.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ztq1996 Do you have any comments on this file? I think you created this code.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you have two copies of this file included.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, right! There are two fftlog.py I added. I also noticed that there already exists another fftlog.py at structure/projection/projection_tools/fftlog.py. The files I added are identical, but includes some updates on top of the original Xiao Fang's code under projection_tools: I added some options to perform the bin averaging operation and the convention of the real and Fourier bin conversion. Do you mind if I modify the fftlog.py under projection_tools?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, just getting back to this! As long as the old functionality is unchanged that's fine.

@joezuntz
Copy link
Owner

Hi @git-sunao - I've had a quick top-level "structural". I'll do a closer look shortly. One thing - please could you add two things:

  • module.yaml files for each new module - you can find samples of these in the other directories. (I use these to auto-generate the documentation pages)
  • an example ini file using the new modules, and add it to the tests/test_cosmosis_standard_library.py tester. If that would need a data file that you don't want to make public yet then you could send it to me directly to test it?

@joezuntz
Copy link
Owner

Hi all - just following up on this - is there anything I can do to help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants