-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HSC 2x2pt pipeline #114
base: main
Are you sure you want to change the base?
HSC 2x2pt pipeline #114
Conversation
Tomography 2x2pt is merged to the main branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this module replicates the existing module in background/astropy_background/astropy_background.py
- is that right? Although yours is probably slightly better as you don't have to choose the model in the setup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ztq1996 Do you have any comments on this file? I think you created this code.
structure/minimalbias/fftlog.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you have two copies of this file included.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, right! There are two fftlog.py I added. I also noticed that there already exists another fftlog.py at structure/projection/projection_tools/fftlog.py. The files I added are identical, but includes some updates on top of the original Xiao Fang's code under projection_tools: I added some options to perform the bin averaging operation and the convention of the real and Fourier bin conversion. Do you mind if I modify the fftlog.py under projection_tools?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, just getting back to this! As long as the old functionality is unchanged that's fine.
Hi @git-sunao - I've had a quick top-level "structural". I'll do a closer look shortly. One thing - please could you add two things:
|
Deleted an unnecessary indent.
…/cosmosis-standard-library-hsc2x2pt into hsc2x2pt-dev pull recent updates from Sunao
Hi all - just following up on this - is there anything I can do to help? |
The pipeline for HSC 2x2pt analysis has been added and validated by me and Tianqing. Here the HSC 2x2pt analysis is the joint analysis of galaxy clustering ($w_{\rm p}$ ) and galaxy-galaxy lensing ($\Delta\Sigma$ ).