Skip to content

Commit

Permalink
Clean up TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
joeyparrish committed Oct 16, 2024
1 parent 514aa83 commit e5dd42b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 9 deletions.
6 changes: 3 additions & 3 deletions emulator-patches/kinetoscope.c
Original file line number Diff line number Diff line change
Expand Up @@ -195,9 +195,9 @@ static void write_sram(const uint8_t* data, uint32_t size) {

for (size_t i = 0; i < size; i++) {
// XOR with 1 swaps every 2 bytes in the output.
// TODO: WHY? This shouldn't be necessary! Is this a bug in the emulator?
// An assumption about what kind of data is in a direct-access buffer?
// Should this nonsense only happen for little-endian builds?
// You wouldn't assume this to be necessary, but the emulated memory is
// accessed as big-endian 16-bit ints or something.
// TODO: Should this nonsense only happen for little-endian builds?
kinetoscope.sram_buffer[kinetoscope.sram_offset ^ 1] = data[i];
kinetoscope.sram_offset++;
}
Expand Down
6 changes: 0 additions & 6 deletions firmware/firmware.ino
Original file line number Diff line number Diff line change
Expand Up @@ -358,12 +358,6 @@ static void process_command(uint8_t command, uint8_t arg) {
}
}

#ifdef DEBUG
// Don't clear the flag too quickly.
// TODO: Determine if this is necessary once hardware prototypes are working.
delay(10 /* ms */);
#endif

clear_cmd();
Serial.println("Command complete.");
}
Expand Down

0 comments on commit e5dd42b

Please sign in to comment.